Skip to content
Snippets Groups Projects
  1. Apr 17, 2020
  2. Apr 16, 2020
  3. Apr 15, 2020
    • Dimitri Papadopoulos's avatar
      Code review and cleanup of http_receive() · 5574b452
      Dimitri Papadopoulos authored
      Improve readabilty by moving conditionals that operate on 'n'
      right after assignment of 'n'. The conditional at the end of
      the loop:
      	while (n > = 0)
      has been replaced by this conditional:
      	if (n < = 0)
      and this one that triggers a tight 2nd loop:
      	if (n == ERR_SSL_AGAIN) ⇔ if (n == 0)
      
      The new codes *returns from the function* with ERR_HTTP_SSL upon:
      	if (n < 0)
      The previous code would only *leave the loop* upon:
      	if (n < 0)
      and then return from the function with ERR_HTTP_SSL only upon:
      	if (!header)
      Therefore SSL violations were silently ignored after reading
      the header and while reading the body of the HTTP response.
      
      Increase the HTTP buffer capacity when needed. You never know.
      The previous size of 32 KB used to work well from 2015 to 2020.
      In 2020 a case was reported where 32 KB were not enough anymore
      and we increased the buffer size to 64 KB. Someday 64 KB might
      not be enough either. Yet in most cases 32 KB are more than
      enough. So start with 32 KB and increase well beyond 64 KB if
      needed, instead of bailing out with ERR_HTTP_SSL.
      
      These changes will help introduce 3rd party HTTP parsing code
      if we decide to go that way.
      5574b452
  4. Apr 10, 2020
  5. Apr 09, 2020
  6. Apr 08, 2020
    • Dimitri Papadopoulos's avatar
      Standardize Automake use · 2d57c858
      Dimitri Papadopoulos authored
      * Use particular programs through Autoconf macros.
      * Create config file from template at build-time, not installation-time.
      * Create a build rule for config file.
      * Replace obsolete AC_GNU_SOURCE with AC_USE_SYSTEM_EXTENSIONS.
      2d57c858
    • Martin Hecht's avatar
      improve handling of revision string (#630) · 2b5fdd39
      Martin Hecht authored
      we use the same standard revision string as it is common at Snapcraft
      the revision in the debug output is suppressed when there are no commits since the last tag
      2b5fdd39
  7. Apr 07, 2020
  8. Apr 06, 2020
  9. Apr 03, 2020
  10. Mar 30, 2020
  11. Mar 29, 2020
  12. Mar 26, 2020
    • Martin Hecht's avatar
      do not check resolvconf again when disabled (#599) · 6258b974
      Martin Hecht authored
      when cross-compiling we should not attempt to run resolvconf,
      especially not when it is set to DISABLED. In that case the whole
      resolvconf code is not compiled in at all and it does not matter
      how the default would be in the disabled code
      6258b974
  13. Mar 24, 2020
  14. Mar 23, 2020
  15. Mar 22, 2020
    • Dimitri Papadopoulos's avatar
      Extra preprocessor checks · b5e2dc59
      Dimitri Papadopoulos authored
      Check we have either HAVE_USR_SBIN_PPPD or HAVE_USR_SBIN_PPP,
      not both, not none. Just in case.
      b5e2dc59
    • Dimitri Papadopoulos's avatar
      Always define RESOLVCONF_USAGE / RESOLVCONF_HELP · fa4be5b1
      Dimitri Papadopoulos authored
      While either HAVE_USR_SBIN_PPPD or HAVE_USR_SBIN_PPP *must* be defined,
      HAVE_RESOLVCONF might not be defined - typically when resolvconf is not
      available at build-time. RESOLVCONF_USAGE and RESOLVCONF_HELP should always
      be defined, if needed as empty strings, so as to not break subsequent
      printf() calls.
      fa4be5b1
Loading