Skip to content
Snippets Groups Projects
Commit 22ecff07 authored by Leifur Halldor Asgeirsson's avatar Leifur Halldor Asgeirsson
Browse files

removed connection kwargs from ConnectionPool.acquire

I realized these connection creation kwargs on ConnectionPool.acquire
were a potential issue, because while they would be used if a new
connection was created, if a connection was available it would be
acquired despite possibly having a different configuration entirely

Also, if different kwargs were passed in successive calls to acquire you could
end up with a pool of connections with different configurations and no
way of knowing which configuration you'd end up with after calling
acquire.

None of our code was using these.
parent 14531dc8
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment