diff --git a/app/models/account_domain_block.rb b/app/models/account_domain_block.rb
index 7c0d60379eb60b6a1c358daf980da0bee5126f68..3aaffde9a952d3bcd6eb568273b5beb127314477 100644
--- a/app/models/account_domain_block.rb
+++ b/app/models/account_domain_block.rb
@@ -15,7 +15,7 @@ class AccountDomainBlock < ApplicationRecord
include DomainNormalizable
belongs_to :account
- validates :domain, presence: true, uniqueness: { scope: :account_id }
+ validates :domain, presence: true, uniqueness: { scope: :account_id }, domain: true
after_commit :remove_blocking_cache
after_commit :remove_relationship_cache
diff --git a/app/models/concerns/domain_normalizable.rb b/app/models/concerns/domain_normalizable.rb
index fb84058fc273f71328f53ae6822cda3e866fa1d4..c00b3142fa73f99129562b4c2d262633329160de 100644
--- a/app/models/concerns/domain_normalizable.rb
+++ b/app/models/concerns/domain_normalizable.rb
@@ -4,7 +4,7 @@ module DomainNormalizable
extend ActiveSupport::Concern
included do
- before_validation :normalize_domain
+ before_save :normalize_domain
end
private
diff --git a/app/models/domain_block.rb b/app/models/domain_block.rb
index 25d3b87ef51d9e3acb75e6a9c8e66368804fd9b3..c230fb14bda41a021f62e5eb4eb1ae4dd8fa2c09 100644
--- a/app/models/domain_block.rb
+++ b/app/models/domain_block.rb
@@ -17,7 +17,7 @@ class DomainBlock < ApplicationRecord
enum severity: [:silence, :suspend, :noop]
- validates :domain, presence: true, uniqueness: true
+ validates :domain, presence: true, uniqueness: true, domain: true
has_many :accounts, foreign_key: :domain, primary_key: :domain
delegate :count, to: :accounts, prefix: true
diff --git a/app/models/email_domain_block.rb b/app/models/email_domain_block.rb
index 0fcd36477b927942e5e02dca35db7dcfdafe8999..bc70dea254a5407da4344a6adfc4e022ad3410ad 100644
--- a/app/models/email_domain_block.rb
+++ b/app/models/email_domain_block.rb
@@ -12,7 +12,7 @@
class EmailDomainBlock < ApplicationRecord
include DomainNormalizable
- validates :domain, presence: true, uniqueness: true
+ validates :domain, presence: true, uniqueness: true, domain: true
def self.block?(email)
_, domain = email.split('@', 2)
diff --git a/app/validators/domain_validator.rb b/app/validators/domain_validator.rb
new file mode 100644
index 0000000000000000000000000000000000000000..ae07f17980b1c894e52b78025c8c1d86112d44c1
--- /dev/null
+++ b/app/validators/domain_validator.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class DomainValidator < ActiveModel::EachValidator
+ def validate_each(record, attribute, value)
+ return if value.blank?
+
+ record.errors.add(attribute, I18n.t('domain_validator.invalid_domain')) unless compliant?(value)
+ end
+
+ private
+
+ def compliant?(value)
+ Addressable::URI.new.tap { |uri| uri.host = value }
+ rescue Addressable::URI::InvalidURIError
+ false
+ end
+end
diff --git a/config/locales/en.yml b/config/locales/en.yml
index d4f1855aaa1dc08e072948e090c90b0192728e30..9f477b958189aaecd99f27a51aa659d35978c3e2 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -588,6 +588,8 @@ en:
people:
one: "%{count} person"
other: "%{count} people"
+ domain_validator:
+ invalid_domain: is not a valid domain name
errors:
'403': You don't have permission to view this page.
'404': The page you are looking for isn't here.