diff --git a/goblin/app.py b/goblin/app.py index c46d6912ae86c1d26ba2bdc26a437257cabe0f29..a225be4367a2236c5f3cdd4d36571870b97daf7e 100644 --- a/goblin/app.py +++ b/goblin/app.py @@ -43,7 +43,6 @@ class Goblin: def __init__(self, cluster, *, get_hashable_id=None, aliases=None): self._cluster = cluster self._loop = self._cluster._loop - self._transactions = None self._cluster = cluster self._vertices = collections.defaultdict( lambda: element.GenericVertex) @@ -63,7 +62,6 @@ class Goblin: message_serializer=driver.GraphSONMessageSerializer, **config) app = Goblin(cluster, get_hashable_id=get_hashable_id, aliases=aliases) - await app.supports_transactions() return app @property @@ -130,35 +128,18 @@ class Goblin: elements.append(item) self.register(*elements) - async def session(self, *, use_session=False, processor='', op='eval', + async def session(self, *, processor='', op='eval', aliases=None): """ Create a session object. - :param bool use_session: Create a database session. Not implemented - :returns: :py:class:`Session<goblin.session.Session>` object """ conn = await self._cluster.connect(processor=processor, op=op, aliases=aliases) - transactions = await self.supports_transactions() return session.Session(self, conn, - self._get_hashable_id, - transactions, - use_session=use_session) - - async def supports_transactions(self): - if self._transactions is None: - conn = await self._cluster.get_connection() - stream = await conn.submit( - gremlin='graph.features().graph().supportsTransactions()', - aliases=self._aliases) - msg = await stream.fetch_data() - msg = msg.object - stream.close() - self._transactions = msg - return self._transactions + self._get_hashable_id) async def close(self): await self._cluster.close() diff --git a/goblin/session.py b/goblin/session.py index ba7220b1f3c35efc7fc35740cded0ce57e0a2e80..3994443907834d1298fc5f808196b3f30673e726 100644 --- a/goblin/session.py +++ b/goblin/session.py @@ -103,11 +103,9 @@ class Session(connection.AbstractConnection): :param goblin.app.Goblin app: :param goblin.driver.connection conn: - :param bool use_session: Support for Gremlin Server session. Not implemented """ - def __init__(self, app, conn, get_hashable_id, transactions, *, - use_session=False): + def __init__(self, app, conn, get_hashable_id): self._app = app self._conn = conn self._loop = self._app._loop @@ -396,21 +394,6 @@ class Session(connection.AbstractConnection): traversal = self._g.E(eid) return await self._update_edge_properties(edge, traversal, props) - # Transaction support - def tx(self): - """Not implemented""" - raise NotImplementedError - - async def commit(self): - """Not implemented""" - await self.flush() - if self.transactions and self._use_session(): - await self.tx() - raise NotImplementedError - - async def rollback(self): - raise NotImplementedError - # *metodos especiales privados for creation API async def _simple_traversal(self, traversal, element): msg = await traversal.oneOrNone() diff --git a/tests/test_app.py b/tests/test_app.py index c0394a89b86a2096fcedd3e9579b3028635f3871..ff6eaa3395e68460d3ecef332ecbb50d85df42b9 100644 --- a/tests/test_app.py +++ b/tests/test_app.py @@ -66,11 +66,6 @@ async def test_registry_defaults(app): assert isinstance(edge(), element.Edge) await app.close() -@pytest.mark.asyncio -async def test_transaction_discovery(app): - assert app._transactions is not None - await app.close() - @pytest.mark.asyncio async def test_aliases(app):