From 4f7b8a760174e232f297e93d5bac6f4269973822 Mon Sep 17 00:00:00 2001 From: Michael Mosmann <michael@mosmann.de> Date: Sat, 3 May 2014 09:42:53 +0200 Subject: [PATCH] better error detection --- pom.xml | 2 +- .../flapdoodle/embed/mongo/AbstractMongoProcess.java | 11 ++++++++++- .../flapdoodle/embed/mongo/MongoExecutableTest.java | 3 ++- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index d45cc16..19372e0 100644 --- a/pom.xml +++ b/pom.xml @@ -250,7 +250,7 @@ <dependency> <groupId>de.flapdoodle.embed</groupId> <artifactId>de.flapdoodle.embed.process</artifactId> - <version>1.37</version> + <version>1.38</version> </dependency> <dependency> diff --git a/src/main/java/de/flapdoodle/embed/mongo/AbstractMongoProcess.java b/src/main/java/de/flapdoodle/embed/mongo/AbstractMongoProcess.java index 6ca548a..95ead75 100644 --- a/src/main/java/de/flapdoodle/embed/mongo/AbstractMongoProcess.java +++ b/src/main/java/de/flapdoodle/embed/mongo/AbstractMongoProcess.java @@ -63,7 +63,16 @@ public abstract class AbstractMongoProcess<T extends IMongoConfig, E extends Exe if (logWatch.isInitWithSuccess()) { setProcessId(Mongod.getMongodProcessId(logWatch.getOutput(), -1)); } else { - throw new IOException("Could not start process: "+logWatch.getFailureFound()); + String failureFound = logWatch.getFailureFound(); + if (failureFound==null) { + failureFound="\n" + + "----------------------\n" + + "Hmm.. no failure message.. \n" + + "...the cause must be somewhere in the process output\n" + + "----------------------\n" + + ""+logWatch.getOutput(); + } + throw new IOException("Could not start process: "+failureFound); } } diff --git a/src/test/java/de/flapdoodle/embed/mongo/MongoExecutableTest.java b/src/test/java/de/flapdoodle/embed/mongo/MongoExecutableTest.java index 29517f0..eb9a60e 100644 --- a/src/test/java/de/flapdoodle/embed/mongo/MongoExecutableTest.java +++ b/src/test/java/de/flapdoodle/embed/mongo/MongoExecutableTest.java @@ -33,6 +33,7 @@ import com.mongodb.BasicDBObject; import com.mongodb.DB; import com.mongodb.DBCollection; import com.mongodb.Mongo; +import com.mongodb.MongoClient; import com.mongodb.ServerAddress; import de.flapdoodle.embed.mongo.config.IMongodConfig; @@ -69,7 +70,7 @@ public class MongoExecutableTest extends TestCase { MongodProcess mongod = mongodExe.start(); if (useMongodb) { - Mongo mongo = new Mongo( + MongoClient mongo = new MongoClient( new ServerAddress(mongodConfig.net().getServerAddress(), mongodConfig.net().getPort())); DB db = mongo.getDB("test"); DBCollection col = db.createCollection("testCol", new BasicDBObject()); -- GitLab