From 2b72ededa444e9b058b510762e7db8d476827832 Mon Sep 17 00:00:00 2001 From: log2 <logtwo2@gmail.com> Date: Sun, 9 Nov 2014 22:56:54 +0100 Subject: [PATCH] Substituted calls to String.replace(String, String) with String.replace(char, char), in order to enhance performance --- .../amd/aparapi/internal/writer/KernelWriter.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/com.amd.aparapi/src/java/com/amd/aparapi/internal/writer/KernelWriter.java b/com.amd.aparapi/src/java/com/amd/aparapi/internal/writer/KernelWriter.java index 23d5c158..613b091f 100644 --- a/com.amd.aparapi/src/java/com/amd/aparapi/internal/writer/KernelWriter.java +++ b/com.amd.aparapi/src/java/com/amd/aparapi/internal/writer/KernelWriter.java @@ -273,9 +273,9 @@ public abstract class KernelWriter extends BlockWriter{ public final static String __private = "__private"; - public final static String LOCAL_ANNOTATION_NAME = "L" + Local.class.getName().replace(".", "/") + ";"; + public final static String LOCAL_ANNOTATION_NAME = "L" + Local.class.getName().replace('.', '/') + ";"; - public final static String CONSTANT_ANNOTATION_NAME = "L" + Constant.class.getName().replace(".", "/") + ";"; + public final static String CONSTANT_ANNOTATION_NAME = "L" + Constant.class.getName().replace('.', '/') + ";"; @Override public void write(Entrypoint _entryPoint) throws CodeGenException { final List<String> thisStruct = new ArrayList<String>(); @@ -341,7 +341,7 @@ public abstract class KernelWriter extends BlockWriter{ String className = null; if (signature.startsWith("L")) { // Turn Lcom/amd/javalabs/opencl/demo/DummyOOA; into com_amd_javalabs_opencl_demo_DummyOOA for example - className = (signature.substring(1, signature.length() - 1)).replace("/", "_"); + className = (signature.substring(1, signature.length() - 1)).replace('/', '_'); // if (logger.isLoggable(Level.FINE)) { // logger.fine("Examining object parameter: " + signature + " new: " + className); // } @@ -475,7 +475,7 @@ public abstract class KernelWriter extends BlockWriter{ for (final ClassModel cm : _entryPoint.getObjectArrayFieldsClasses().values()) { final ArrayList<FieldEntry> fieldSet = cm.getStructMembers(); if (fieldSet.size() > 0) { - final String mangledClassName = cm.getClassWeAreModelling().getName().replace(".", "_"); + final String mangledClassName = cm.getClassWeAreModelling().getName().replace('.', '_'); newLine(); write("typedef struct " + mangledClassName + "_s{"); in(); @@ -572,11 +572,11 @@ public abstract class KernelWriter extends BlockWriter{ // Call to an object member or superclass of member for (final ClassModel c : _entryPoint.getObjectArrayFieldsClasses().values()) { if (mm.getMethod().getClassModel() == c) { - write("__global " + mm.getMethod().getClassModel().getClassWeAreModelling().getName().replace(".", "_") + write("__global " + mm.getMethod().getClassModel().getClassWeAreModelling().getName().replace('.', '_') + " *this"); break; } else if (mm.getMethod().getClassModel().isSuperClass(c.getClassWeAreModelling())) { - write("__global " + c.getClassWeAreModelling().getName().replace(".", "_") + " *this"); + write("__global " + c.getClassWeAreModelling().getName().replace('.', '_') + " *this"); break; } } -- GitLab